Refactor internal package structure #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgodlewski
force-pushed
the
kg/internal-refactor
branch
from
8716ef5 to
f4c7b48
Compare
PatrykGala
requested changes
Nov 22, 2024
@PatrykGala - shouldn't that be fine as we are in beta and are being used only by limited beta-testers who we can directly reach out to upgrade to newer versions? |
|
PatrykGala
approved these changes
Nov 22, 2024
|
I moved the file so the import statement is now more user-friendly, I think it's a good catch. The |
PatrykGala
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move things around according to their responsibility to cleanup the structure. I did not make it too elaborate for the time being, just an overdue cleanup.
Packages are as follows:
api- everything that is user-facing:Run& exceptionsnet- code related to communicating with the backendsync- sync process, queues etcutil- things like logging,SharedVar,ProcessLink